net: batman-adv: fix error handling
No exploitation in the wild has been reported. EPSS puts the chance of exploitation in the next 30 days at 1%. Fixed in Kernel 07533f1a673ce1126d0a72ef1e4b5eaaa3dd6d20, Kernel 0c6b199f09be489c48622537a550787fc80aea73, Kernel 6422e8471890273994fe8cc6d452b0dcd2c9483e and 5 more.
In the Linux kernel, the following vulnerability has been resolved: net: batman-adv: fix error handling Syzbot reported ODEBUG warning in batadv_nc_mesh_free(). The problem was in wrong error handling in batadv_mesh_init(). Before this patch batadv_mesh_init() was calling batadv_mesh_free() in case of any batadv_*_init() calls failure. This approach may work well, when there is some kind of indicator, which can tell which parts of batadv are initialized; but there isn't any. All written above lead to cleaning up uninitialized fields. Even if we hide ODEBUG warning by initializing bat_priv->nc.work, syzbot was able to hit GPF in batadv_nc_purge_paths(), because hash pointer in still NULL. [1] To fix these bugs we can unwind batadv_*_init() calls one by one. It is good approach for 2 reasons: 1) It fixes bugs on error handling path 2) It improves the performance, since we won't call unneeded batadv_*_free() functions. So, this patch makes all batadv_*_init() clean up all allocated memory before returning with an error to no call correspoing batadv_*_free() and open-codes batadv_mesh_free() with proper order to avoid touching uninitialized fields.
Affected
Vendors, products and packages with version ranges
| Vendor | Product | Versions | Fixed |
|---|---|---|---|
| Linux | Kernel | =2.6.38, >=c6c8fea29769d998d94fcec9b9f14d4b52b349d3 <07533f1a673ce1126d0a72ef1e4b5eaaa3dd6d20, >=c6c8fea29769d998d94fcec9b9f14d4b52b349d3 <0c6b199f09be489c48622537a550787fc80aea73, >=c6c8fea29769d998d94fcec9b9f14d4b52b349d3 <6422e8471890273994fe8cc6d452b0dcd2c9483e, >=c6c8fea29769d998d94fcec9b9f14d4b52b349d3 <6f68cd634856f8ca93bafd623ba5357e0f648c68, >=c6c8fea29769d998d94fcec9b9f14d4b52b349d3 <a8f7359259dd5923adc6129284fdad12fc5db347, >=c6c8fea29769d998d94fcec9b9f14d4b52b349d3 <b0a2cd38553c77928ef1646ed1518486b1e70ae8, >=c6c8fea29769d998d94fcec9b9f14d4b52b349d3 <e50f957652190b5a88a8ebce7e5ab14ebd0d3f00, >=c6c8fea29769d998d94fcec9b9f14d4b52b349d3 <fbf150b16a3635634b7dfb7f229d8fcd643c6c51 | 07533f1a673ce1126d0a72ef1e4b5eaaa3dd6d20, 0c6b199f09be489c48622537a550787fc80aea73, 6422e8471890273994fe8cc6d452b0dcd2c9483e, 6f68cd634856f8ca93bafd623ba5357e0f648c68, a8f7359259dd5923adc6129284fdad12fc5db347, b0a2cd38553c77928ef1646ed1518486b1e70ae8, e50f957652190b5a88a8ebce7e5ab14ebd0d3f00, fbf150b16a3635634b7dfb7f229d8fcd643c6c51 |
Timeline
Every event on this vulnerability
Related
Other vulnerabilities in Kernel, strongest first
Embed
A live severity badge for an advisory, README or ticket