wifi: brcmfmac: Fix oops due to NULL pointer dereference in brcmf_sdiod_sglist_rw()
No exploitation in the wild has been reported. EPSS puts the chance of exploitation in the next 30 days at 0%. Fixed in Kernel 07c020c6d14d29e5a3ea4e4576b8ecf956a80834, Kernel 342f87d263462c2670b77ea9a32074cab2ac6fa1, Kernel 34941321b516bd7c6103bd01287d71a1804d19d3 and 4 more.
In the Linux kernel, the following vulnerability has been resolved: wifi: brcmfmac: Fix oops due to NULL pointer dereference in brcmf_sdiod_sglist_rw() This patch fixes a NULL pointer dereference bug in brcmfmac that occurs when a high 'sd_sgentry_align' value applies (e.g. 512) and a lot of queued SKBs are sent from the pkt queue. The problem is the number of entries in the pre-allocated sgtable, it is nents = max(rxglom_size, txglom_size) + max(rxglom_size, txglom_size) >> 4 + 1. Given the default [rt]xglom_size=32 it's actually 35 which is too small. Worst case, the pkt queue can end up with 64 SKBs. This occurs when a new SKB is added for each original SKB if tailroom isn't enough to hold tail_pad. At least one sg entry is needed for each SKB. So, eventually the "skb_queue_walk loop" in brcmf_sdiod_sglist_rw may run out of sg entries. This makes sg_next return NULL and this causes the oops. The patch sets nents to max(rxglom_size, txglom_size) * 2 to be able handle the worst-case. Btw. this requires only 64-35=29 * 16 (or 20 if CONFIG_NEED_SG_DMA_LENGTH) = 464 additional bytes of memory.
Affected
Vendors, products and packages with version ranges
| Vendor | Product | Versions | Fixed |
|---|---|---|---|
| Linux | Kernel | =3.15, >=af1fa210f4fc6e304b859b386a3c8a266b1110ab <07c020c6d14d29e5a3ea4e4576b8ecf956a80834, >=af1fa210f4fc6e304b859b386a3c8a266b1110ab <342f87d263462c2670b77ea9a32074cab2ac6fa1, >=af1fa210f4fc6e304b859b386a3c8a266b1110ab <34941321b516bd7c6103bd01287d71a1804d19d3, >=af1fa210f4fc6e304b859b386a3c8a266b1110ab <67a25ea28f8ec1da8894f2f115d01d3becf67dc7, >=af1fa210f4fc6e304b859b386a3c8a266b1110ab <7522d7d745d13fbeff3350fe6aa56c8dae263571, >=af1fa210f4fc6e304b859b386a3c8a266b1110ab <857282b819cbaa0675aaab1e7542e2c0579f52d7, >=af1fa210f4fc6e304b859b386a3c8a266b1110ab <dfb3f9d3f602602de208da7bdcc0f6d5ee74af68 | 07c020c6d14d29e5a3ea4e4576b8ecf956a80834, 342f87d263462c2670b77ea9a32074cab2ac6fa1, 34941321b516bd7c6103bd01287d71a1804d19d3, 67a25ea28f8ec1da8894f2f115d01d3becf67dc7, 7522d7d745d13fbeff3350fe6aa56c8dae263571, 857282b819cbaa0675aaab1e7542e2c0579f52d7, dfb3f9d3f602602de208da7bdcc0f6d5ee74af68 |
Timeline
Every event on this vulnerability
Related
Other vulnerabilities in Kernel, strongest first
Embed
A live severity badge for an advisory, README or ticket