USB: dummy-hcd: Fix locking/synchronization error
No exploitation in the wild has been reported. EPSS puts the chance of exploitation in the next 30 days at 0%. Fixed in Kernel 3.3, Kernel 4.2, Kernel 5.10.253 and 18 more.
In the Linux kernel, the following vulnerability has been resolved: USB: dummy-hcd: Fix locking/synchronization error Syzbot testing was able to provoke an addressing exception and crash in the usb_gadget_udc_reset() routine in drivers/usb/gadgets/udc/core.c, resulting from the fact that the routine was called with a second ("driver") argument of NULL. The bad caller was set_link_state() in dummy_hcd.c, and the problem arose because of a race between a USB reset and driver unbind. These sorts of races were not supposed to be possible; commit 7dbd8f4cabd9 ("USB: dummy-hcd: Fix erroneous synchronization change"), along with a few followup commits, was written specifically to prevent them. As it turns out, there are (at least) two errors remaining in the code. Another patch will address the second error; this one is concerned with the first. The error responsible for the syzbot crash occurred because the stop_activity() routine will sometimes drop and then re-acquire the dum->lock spinlock. A call to stop_activity() occurs in set_link_state() when handling an emulated USB reset, after the test of dum->ints_enabled and before the increment of dum->callback_usage. This allowed another thread (doing a driver unbind) to sneak in and grab the spinlock, and then clear dum->ints_enabled and dum->driver. Normally this other thread would have to wait for dum->callback_usage to go down to 0 before it would clear dum->driver, but in this case it didn't have to wait since dum->callback_usage had not yet been incremented. The fix is to increment dum->callback_usage _before_ calling stop_activity() instead of after. Then the thread doing the unbind will not clear dum->driver until after the call to usb_gadget_udc_reset() safely returns and dum->callback_usage has been decremented again.
Affected
Vendors, products and packages with version ranges
| Vendor | Product | Versions | Fixed |
|---|---|---|---|
| Linux | Kernel | =7.0, >=3.2.97 <3.3, >=4.1.46 <4.2, >=4.14 <5.10.253, >=4.4.92 <4.5, >=4.9.55 <4.10, >=5.11 <5.15.203, >=5.16 <6.1.168, >=6.13 <6.18.22, >=6.19 <6.19.12, >=6.2 <6.6.134, >=6.7 <6.12.81, >=3.16.52 <3.17, >=4.13.6 <4.14, >=7dbd8f4cabd96db5a50513de9d83a8105a5ffc81 <218886b2ef2dea7627d3700ab0abaf4bf9d1161f, >=7dbd8f4cabd96db5a50513de9d83a8105a5ffc81 <616a63ff495df12863692ab3f9f7b84e3fa7a66d, >=7dbd8f4cabd96db5a50513de9d83a8105a5ffc81 <6350c7dd33ab481ef41c931a238361490c32d15c, >=7dbd8f4cabd96db5a50513de9d83a8105a5ffc81 <69ab97a693251d6a6093e630060a3c744fd58524, >=7dbd8f4cabd96db5a50513de9d83a8105a5ffc81 <791966f85b439b261bf19865cf1c07c065ffb4b4, >=7dbd8f4cabd96db5a50513de9d83a8105a5ffc81 <805b1833d6ed6da5086e610578a28e71bb54fbbb, >=7dbd8f4cabd96db5a50513de9d83a8105a5ffc81 <cc97fb5969177cccce2e23b31298df220fc7570d, >=7dbd8f4cabd96db5a50513de9d83a8105a5ffc81 <efbd9441f1e769a7aae1813d497cec09cbdff031, =4.14, =4f8ae1fcb0dfbb72a7678f81bf01fb7fc85c6715, =7b416b9dac6ede26d4ca0c1a88b448b543623ff3, =8590bc1da625dd4a589eac0fc3aa3cf4f400424d, =a867d5b932ac4911d3f8a1e63505061b0c81f889, =e39b17143a5b5aac81f066d455e5d3a9877eb3ae, =e84b4a008365b7edbd842a063ae28d040a98db25 | 3.3, 4.2, 5.10.253, 4.5, 4.10, 5.15.203, 6.1.168, 6.18.22, 6.19.12, 6.6.134, 6.12.81, 3.17, 4.14, 218886b2ef2dea7627d3700ab0abaf4bf9d1161f, 616a63ff495df12863692ab3f9f7b84e3fa7a66d, 6350c7dd33ab481ef41c931a238361490c32d15c, 69ab97a693251d6a6093e630060a3c744fd58524, 791966f85b439b261bf19865cf1c07c065ffb4b4, 805b1833d6ed6da5086e610578a28e71bb54fbbb, cc97fb5969177cccce2e23b31298df220fc7570d, efbd9441f1e769a7aae1813d497cec09cbdff031 |
| linux-kernel: Kernel | >=3.16.52 <3.17, >=3.2.97 <3.3, >=4.1.46 <4.2, >=4.13.6 <4.14, >=4.14.0 <5.10.253, >=4.4.92 <4.5, >=4.9.55 <4.10, >=5.11.0 <5.15.203, >=5.16.0 <6.1.168, >=6.13.0 <6.18.22, >=6.19.0 <6.19.12, >=6.2.0 <6.6.134, >=6.7.0 <6.12.81 | 3.17, 3.3, 4.2, 4.14, 5.10.253, 4.5, 4.10, 5.15.203, 6.1.168, 6.18.22, 6.19.12, 6.6.134, 6.12.81 |
Timeline
Every event on this vulnerability
Related
Other vulnerabilities in Kernel, strongest first
Embed
A live severity badge for an advisory, README or ticket