smb: client: fix heap overflow in DACL owner/group rewrite
A public exploit exists; no exploitation in the wild has been reported. EPSS puts the chance of exploitation in the next 30 days at 1%. Fixed in Kernel fb736ab4fb8c4fdb8b2f9ccd3a62e03d11549ca1, Kernel 0ee150794c75bcd0be0e24ff3394f433cbae18cc, Kernel 2a9aee9ef5622d58d8aafaa3263b3ffe70e2d9dd and 10 more.
In the Linux kernel, the following vulnerability has been resolved: smb: client: fix heap overflow in DACL owner/group rewrite When id_mode_to_cifs_acl rewrites an existing DACL, it allocates a buffer sized according to the on-disk DACL length reported by dacl_ptr->size. However, replace_sids_and_copy_aces may rewrite each ACE with a new owner/group SID obtained from the cifs.idmap upcall. Those SIDs can have up to SID_MAX_SUB_AUTHORITIES (15) sub-authorities, making each ACE up to 76 bytes (sizeof(struct smb_ace)). If the original DACL contains short SIDs (e.g., 1 sub-authority) while the replacement SIDs are long, the rewritten ACEs overflow the allocation. Fix this by always budgeting for worst-case SID expansion: allocate sizeof(struct smb_acl) plus num_aces * sizeof(struct smb_ace), which covers the smb_acl header and room for every ACE at maximum SID size. This replaces the previous split logic that used dacl_ptr->size for cifsacl mounts but num_aces * sizeof(struct smb_ace) for mode_from_sid mounts: both paths can trigger the same rewrite and need the same headroom. KASAN reports this as: BUG: KASAN: slab-out-of-bounds in build_sec_desc+0x1e8a/0x2680 [cifs] Write of size 4 at addr ffff8881a5e25374 by task chown/5298 ... The buggy address is located 0 bytes to the right of allocated 884-byte region [ffff8881a5e25000, ffff8881a5e25374)
Affected
Vendors, products and packages with version ranges
| Vendor | Product | Versions | Fixed |
|---|---|---|---|
| Linux | Kernel | >=bc3e9dd9d104ca1b75644eab87b38ce8a924aef4 <fb736ab4fb8c4fdb8b2f9ccd3a62e03d11549ca1, >=bc3e9dd9d104ca1b75644eab87b38ce8a924aef4 <0ee150794c75bcd0be0e24ff3394f433cbae18cc, >=bc3e9dd9d104ca1b75644eab87b38ce8a924aef4 <2a9aee9ef5622d58d8aafaa3263b3ffe70e2d9dd, >=bc3e9dd9d104ca1b75644eab87b38ce8a924aef4 <4e78b5ff13214353750b87283ff79f62510f5844, >=bc3e9dd9d104ca1b75644eab87b38ce8a924aef4 <63c2fbde15ffc9a0c21adf670c38d028e20fa65c, >=bc3e9dd9d104ca1b75644eab87b38ce8a924aef4 <7fa84c9ca690643f429ae2709584a47e74b572c9, >=bc3e9dd9d104ca1b75644eab87b38ce8a924aef4 <d5cea6766ae1868a51c7d17d77d065b4f55c587f, =5.12 | fb736ab4fb8c4fdb8b2f9ccd3a62e03d11549ca1, 0ee150794c75bcd0be0e24ff3394f433cbae18cc, 2a9aee9ef5622d58d8aafaa3263b3ffe70e2d9dd, 4e78b5ff13214353750b87283ff79f62510f5844, 63c2fbde15ffc9a0c21adf670c38d028e20fa65c, 7fa84c9ca690643f429ae2709584a47e74b572c9, d5cea6766ae1868a51c7d17d77d065b4f55c587f |
| linux-kernel: Kernel | >=5.16.0 <6.1.191, >=6.13.0 <6.18.53, >=6.19.0 <7.2.7, >=6.2.0 <6.6.158, >=6.7.0 <6.12.111, >=5.12.0 <5.15.224 | 6.1.191, 6.18.53, 7.2.7, 6.6.158, 6.12.111, 5.15.224 |
Exploit evidence
1 public sources
Timeline
Every event on this vulnerability
Related
Other vulnerabilities in Kernel, strongest first
Embed
A live severity badge for an advisory, README or ticket