ice: add missing xa_destroy for sched_node_ids
No exploitation in the wild has been reported. EPSS puts the chance of exploitation in the next 30 days at 0%. Fixed in Kernel 09a7cdf8fffb065a8aa30cfa604ff4a65cbf04c9, Kernel 53432c4c3e869076350aef319534431af8ba99c1, Kernel c075a91fe5762d314e6e182d37d29cf874bd314a and 8 more.
In the Linux kernel, the following vulnerability has been resolved: ice: add missing xa_destroy for sched_node_ids Commit 16dfa49406bc ("ice: Introduce new parameters in ice_sched_node") added a sched_node_ids xarray to the port info structure, but never called xa_destroy on it. Since xarrays can allocate internal memory, this can result in a memory leak even if every element in the xarray has been removed. The xarray is currently embedded in the port_info structure. This appears to have been done because its use is within functions that take the port_info as a primary argument. However, this complicates managing the lifecycle of the field. The port_info structure is allocated in ice_init_hw() using devm, and it is not released until the devm cleanup when the driver is unloaded. The ice_init_hw() function is called in many places, including devlink reload, and possibly during DDP load after updating the Tx scheduler layout. Adding a call of xa_destroy to the ice_deinit_hw() causes Sashiko to raise multiple concerns due to potential ordering issues and possible ways that port_info could be a dangling reference. To handle this, move the sched_node_ids out of port_info and into the hw structure. All users of the array already have a pointer to hw anyways, and there is only one sched_node_ids per adapter. While here, remove the overly verbose comment explaining the nature of the sched_node_ids xarray. Add the missing xa_destroy to the cleanup path and to ice_deinit_hw(), ensuring that we properly release the xarray memory. This was caught by Sashiko during development of unrelated code.
Affected
Vendors, products and packages with version ranges
| Vendor | Product | Versions | Fixed |
|---|---|---|---|
| Linux | Kernel | >=a388961be5ed8ee037ac68220e389bc4e9339a39 <09a7cdf8fffb065a8aa30cfa604ff4a65cbf04c9, >=16dfa49406bc5e1f4cbb115027cbd719d7e6c930 <53432c4c3e869076350aef319534431af8ba99c1, >=16dfa49406bc5e1f4cbb115027cbd719d7e6c930 <c075a91fe5762d314e6e182d37d29cf874bd314a, >=16dfa49406bc5e1f4cbb115027cbd719d7e6c930 <d6f38fb12069fb1edf762962b5fcf3f42d643b47, >=16dfa49406bc5e1f4cbb115027cbd719d7e6c930 <f5463bc124c0d6f922e272336584730c5c61c4f1, >=6.1.95 <6.1.189, =6.2, >=16dfa49406bc5e1f4cbb115027cbd719d7e6c930 <44cdd6b7e036303f7fecf841cf23c05a4a4faf2d | 09a7cdf8fffb065a8aa30cfa604ff4a65cbf04c9, 53432c4c3e869076350aef319534431af8ba99c1, c075a91fe5762d314e6e182d37d29cf874bd314a, d6f38fb12069fb1edf762962b5fcf3f42d643b47, f5463bc124c0d6f922e272336584730c5c61c4f1, 6.1.189, 44cdd6b7e036303f7fecf841cf23c05a4a4faf2d |
| linux-kernel: Kernel | >=6.13.0 <6.18.53, >=6.19.0 <7.2.7, >=6.2.0 <6.6.158, >=6.7.0 <6.12.111, >=6.1.95 <6.1.189 | 6.18.53, 7.2.7, 6.6.158, 6.12.111, 6.1.189 |
Timeline
Every event on this vulnerability
Related
Other vulnerabilities in Kernel, strongest first
Embed
A live severity badge for an advisory, README or ticket