xfrm: add missing rcu_read_lock(), skb_dst_force() and dev_hold() for xfrm_trans_reinject()
No exploitation in the wild has been reported. EPSS puts the chance of exploitation in the next 30 days at 0%. Fixed in Kernel 41e47f1664be86c91326f0afe0504a1162d00907, Kernel 6601d91a85761f33351c71e04ec0bbd294ca07ce, Kernel 664fc0941df7c1918b2cd4de6ee00469ba77d8e4 and 12 more.
In the Linux kernel, the following vulnerability has been resolved: xfrm: add missing rcu_read_lock(), skb_dst_force() and dev_hold() for xfrm_trans_reinject() syzbot reported a suspicious RCU usage warning in ip6_pkt_drop(): WARNING: suspicious RCU usage in ip6_pkt_drop include/net/addrconf.h:389 suspicious rcu_dereference_check() usage! Call Trace: __in6_dev_get_safely include/net/addrconf.h:389 [inline] ip6_pkt_drop+0x596/0x610 net/ipv6/route.c:4620 ip6_pkt_discard+0x1c/0x30 net/ipv6/route.c:4651 xfrm_trans_reinject+0x324/0x630 net/xfrm/xfrm_input.c:806 process_one_work kernel/workqueue.c:3322 [inline] process_scheduled_works+0xa8e/0x14e0 kernel/workqueue.c:3405 worker_thread+0xa47/0xfb0 kernel/workqueue.c:3486 When commit 4f4920669d21 ("xfrm: Reinject transport-mode packets through workqueue") converted xfrm_trans_reinject from a tasklet to a workqueue, the reinjection loop ceased running in softirq context. Workqueue workers run in process context where local_bh_disable() does not enter an RCU read-side critical section under CONFIG_PREEMPT_RCU. Because finish callbacks (such as ip6_rcv_finish) expect to run under an RCU read lock (performing route lookups, l3mdev lookups, and accessing RCU-protected data structures), invoking them in workqueue context without rcu_read_lock() triggers RCU lockdep warnings. Furthermore, packets queued to the workqueue via xfrm_trans_queue_net() may carry non-refcounted (noref) dst entries (e.g. from ip_route_input_noref). Additionally, on netdevice unregistration, dst_dev_put() replaces dst->dev with blackhole_netdev, so dst entries do not keep skb->dev alive while queued in the workqueue. Fix these issues by: 1. Calling skb_dst_force(skb) in xfrm_trans_queue_net() while still in the caller's RCU section to ensure dst is reference-counted before queuing. 2. Holding a reference on skb->dev via dev_hold()/dev_put() across workqueue deferral so skb->dev remains valid during finish() callback processing. 3. Acquiring rcu_read_lock() around the finish callback invocation loop in xfrm_trans_reinject().
Affected
Vendors, products and packages with version ranges
| Vendor | Product | Versions | Fixed |
|---|---|---|---|
| Linux | Kernel | >=7d98b26684cb2390729525b341ea099f0badbe18 <41e47f1664be86c91326f0afe0504a1162d00907, >=4f4920669d21e1060b7243e5118dc3b71ced1276 <6601d91a85761f33351c71e04ec0bbd294ca07ce, >=4f4920669d21e1060b7243e5118dc3b71ced1276 <664fc0941df7c1918b2cd4de6ee00469ba77d8e4, >=4f4920669d21e1060b7243e5118dc3b71ced1276 <68a317b4aec8ca1868a39d69e40f9e29baa4f40a, >=4f4920669d21e1060b7243e5118dc3b71ced1276 <6eb3b071be8e260543c604550c54dac66e6b174b, >=4f4920669d21e1060b7243e5118dc3b71ced1276 <d2f5082f9e84653fa1a9e8aebaaff23e688f5e19, >=5.15.75 <5.15.222, >=5.19.17 <5.20, >=6.0.3 <6.1, =130d9e5017ade1b81d16783563edb38c12a2eab7, =6.1, =f520075da484306bbb8425afd2c42404ba74816f, >=4f4920669d21e1060b7243e5118dc3b71ced1276 <0cda8273265d30cac6423834fd7d4acb75f04fdb | 41e47f1664be86c91326f0afe0504a1162d00907, 6601d91a85761f33351c71e04ec0bbd294ca07ce, 664fc0941df7c1918b2cd4de6ee00469ba77d8e4, 68a317b4aec8ca1868a39d69e40f9e29baa4f40a, 6eb3b071be8e260543c604550c54dac66e6b174b, d2f5082f9e84653fa1a9e8aebaaff23e688f5e19, 5.15.222, 5.20, 6.1, 0cda8273265d30cac6423834fd7d4acb75f04fdb |
| linux-kernel: Kernel | >=5.19.17 <5.20, >=6.0.3 <6.1, >=6.1.0 <6.1.189, >=6.13.0 <6.18.54, >=6.19.0 <7.2.8, >=6.2.0 <6.6.158, >=6.7.0 <6.12.112, >=5.15.75 <5.15.222 | 5.20, 6.1, 6.1.189, 6.18.54, 7.2.8, 6.6.158, 6.12.112, 5.15.222 |
Timeline
Every event on this vulnerability
Related
Other vulnerabilities in Kernel, strongest first
Embed
A live severity badge for an advisory, README or ticket