KVM: PPC: Book3S HV: Add preempt_disable() around virtual-mode HPTE bit-lock users
No exploitation in the wild has been reported. EPSS puts the chance of exploitation in the next 30 days at 0%. Fixed in Kernel abbbe5ff83e7c9ed3a4d61b73011f1df7bf87907, Kernel 7a02dfbd2f4a7dec468221d639f740a51d4483e1, Kernel 8f021a671b511a49468e87a4935b43b0a4d045c0 and 4 more.
In the Linux kernel, the following vulnerability has been resolved: KVM: PPC: Book3S HV: Add preempt_disable() around virtual-mode HPTE bit-lock users kvmppc_hv_find_lock_hpte() requires virtual-mode callers to run with preemption disabled, because it can return with HPTE_V_HVLOCK still held until the caller later unlocks the HPTE. Existing virtual-mode callers in book3s_64_mmu_hv.c already follow that rule. Two virtual-mode call paths do not: 1. kvmppc_handle_exit_hv() calls kvmppc_hpte_hv_fault() for hash-mode data-side and instruction-side faults after guest exit, with preemption already enabled. kvmppc_hpte_hv_fault() calls kvmppc_hv_find_lock_hpte() directly. 2. kvmppc_pseries_do_hcall() executes virtual-mode handlers for HPT hcalls via kvmppc_pseries_do_hpt_hcall() with preemption enabled. The handlers for H_ENTER, H_REMOVE, H_READ, H_CLEAR_MOD, H_CLEAR_REF, H_PROTECT, and H_BULK_REMOVE spin on try_lock_hpte() or lock_rmap(), and H_ENTER also reaches kvmppc_do_h_enter(), which uses arch_spin_lock() on kvm->mmu_lock. That raw lock choice is intentional because kvmppc_do_h_enter() is also used by real-mode callers, so the correct fix is to establish the proper preemption context at the virtual-mode caller boundary. If a vCPU thread is preempted while holding HPTE_V_HVLOCK, any other thread on the same CPU trying to acquire the same bit-lock can spin indefinitely. The same applies to lock_rmap() users and to the H_ENTER path while holding the raw mmu_lock. Fix this by adding preempt_disable()/preempt_enable() pairs around the two kvmppc_hpte_hv_fault() call sites in kvmppc_handle_exit_hv(), and around the kvmppc_pseries_do_hpt_hcall() invocation in kvmppc_pseries_do_hcall(). Targeting only the HPT hcall helper avoids wrapping non-HPT hcalls (such as H_RTAS, H_CONFER, H_REGISTER_VPA) that perform page faults, blocking memory allocations, or context switches.
Affected
Vendors, products and packages with version ranges
| Vendor | Product | Versions | Fixed |
|---|---|---|---|
| Linux | Kernel | >=6165d5dd99dbaec7a309491c3951bd81fc89978d <abbbe5ff83e7c9ed3a4d61b73011f1df7bf87907, >=6165d5dd99dbaec7a309491c3951bd81fc89978d <7a02dfbd2f4a7dec468221d639f740a51d4483e1, >=6165d5dd99dbaec7a309491c3951bd81fc89978d <8f021a671b511a49468e87a4935b43b0a4d045c0, >=6165d5dd99dbaec7a309491c3951bd81fc89978d <9ffe72ff3f1ef66dc554ecafbe0861c8c118eb41, =5.14 | abbbe5ff83e7c9ed3a4d61b73011f1df7bf87907, 7a02dfbd2f4a7dec468221d639f740a51d4483e1, 8f021a671b511a49468e87a4935b43b0a4d045c0, 9ffe72ff3f1ef66dc554ecafbe0861c8c118eb41 |
| linux-kernel: Kernel | >=6.13.0 <6.18.61, >=6.19.0 <7.3.2, >=5.14.0 <6.12.117 | 6.18.61, 7.3.2, 6.12.117 |
Timeline
Every event on this vulnerability
Related
Other vulnerabilities in Kernel, strongest first
Embed
A live severity badge for an advisory, README or ticket