pps: generators: don't use the driver's info after unregister
No exploitation in the wild has been reported. EPSS puts the chance of exploitation in the next 30 days at 0%. Fixed in Kernel 4e8063cae337cb7328e6856235cf4de5d165516e, Kernel a7ba1a5a0c16d3aad161681b01933703419fd52d, Kernel ea2aaf6bda6ba90e92abe3aeaff426bba082c0eb and 2 more.
In the Linux kernel, the following vulnerability has been resolved: pps: generators: don't use the driver's info after unregister A file that was opened before pps_gen_unregister_source() keeps pps_gen, and with it the pointer to the driver's pps_gen_source_info. PPS_GEN_SETENABLE and PPS_GEN_USESYSTEMCLOCK keep using that pointer after the driver has gone: - pps_gen_tio allocates its info with devm_kzalloc(), so after an unbind both ioctls read freed memory, and SETENABLE calls the driver's enable() with its freed private data. - pps_gen-dummy does not set info->owner, so it can be unloaded while the file is open, and the ioctls then read the unloaded module's data and call its code. TIO can't probe in a VM, as it needs ART. A test driver that registers its info in devm memory like TIO does, unbound while /dev/pps-gen0 is open, gives: BUG: KASAN: slab-use-after-free in pps_gen_cdev_ioctl+0x4c1/0x580 Read of size 1 at addr ffff88800e647f38 by task ppsgen64/145 ... Freed by task 146: kfree+0x25a/0x6d0 release_nodes+0xd1/0x140 devres_release_all+0x10e/0x1a0 device_unbind_cleanup+0x71/0x250 device_release_driver_internal+0x41b/0x570 unbind_store+0xd9/0x100 and unloading pps_gen-dummy while its file is open oopses: BUG: unable to handle page fault for address: ffffffffa0203040 Oops: Oops: 0000 [#1] SMP KASAN NOPTI RIP: 0010:pps_gen_cdev_ioctl+0x372/0x580 Protect info in the ioctl handler with a mutex, and clear it under the mutex on unregister, so that unregister waits for the ioctls using it and later ones fail with -ENODEV. PPS_KC_BIND does the same for a removed PPS device since commit 3649f9a6b897 ("pps: don't allow PPS_KC_BIND on removed devices"). The sysfs attributes need nothing new: they are removed, and their callbacks drained, before info is cleared.
Affected
Vendors, products and packages with version ranges
| Vendor | Product | Versions | Fixed |
|---|---|---|---|
| Linux | Kernel | =6.14, >=86b525bed2758878e788c9fb6b8fb281fd61bdb0 <4e8063cae337cb7328e6856235cf4de5d165516e, >=86b525bed2758878e788c9fb6b8fb281fd61bdb0 <a7ba1a5a0c16d3aad161681b01933703419fd52d, >=86b525bed2758878e788c9fb6b8fb281fd61bdb0 <ea2aaf6bda6ba90e92abe3aeaff426bba082c0eb | 4e8063cae337cb7328e6856235cf4de5d165516e, a7ba1a5a0c16d3aad161681b01933703419fd52d, ea2aaf6bda6ba90e92abe3aeaff426bba082c0eb |
| linux-kernel: Kernel | >=6.14.0 <6.18.63, >=6.19.0 <7.3.2 | 6.18.63, 7.3.2 |
Timeline
Every event on this vulnerability
Related
Other vulnerabilities in Kernel, strongest first
Embed
A live severity badge for an advisory, README or ticket