nvme: Do not drop the cdev reference twice when cdev_device_add() fails
No exploitation in the wild has been reported. EPSS puts the chance of exploitation in the next 30 days at 0%. Fixed in Kernel 45d0c2d7d338ae1606984ed92d254ca0efcef921, Kernel 7dfe79db5615df8d37ae7de6d3ec099b71bf3e03, Kernel 7.3 and 1 more.
In the Linux kernel, the following vulnerability has been resolved: nvme: Do not drop the cdev reference twice when cdev_device_add() fails Since commit 9952f3882ecb ("nvme: fix cdev lifetime"), nvme_add_ns_cdev() and nvme_add_ns_head_cdev() take a reference to the namespace (or namespace head) before calling nvme_cdev_add(), to be dropped by the char device's release, nvme_cdev_rel(), and drop it themselves when nvme_cdev_add() fails. But when cdev_device_add() fails, nvme_cdev_add() has already put the device, and nvme_cdev_rel() has already dropped that reference: the caller drops it a second time. With one allocation failure injected into cdev_device_add() for a namespace on an NVMe over loop controller, deleting the controller gives, with native multipath: BUG: KASAN: slab-use-after-free in nvme_put_ns_head+0x21/0x140 Write of size 4 at addr ff1100000a4ea078 by task init/1 nvme_put_ns_head nvme_put_ns nvme_remove_namespaces nvme_do_delete_ctrl nvme_delete_ctrl_sync nvme_sysfs_delete Freed by task 1: kfree nvme_ns_remove nvme_remove_namespaces refcount_t: underflow; use-after-free. Take the reference in nvme_cdev_add() instead, right before cdev_device_add(), and let the callers neither take nor drop it. Add nvme_is_ns_cdev() for the check that nvme_cdev_rel() and nvme_cdev_add() now share.
Affected
Vendors, products and packages with version ranges
| Vendor | Product | Versions | Fixed |
|---|---|---|---|
| Linux | Kernel | =98b09ad7934482e64db4b4477d91e3bbf43adf4c, >=9952f3882ecba709092379b71e02b09762b26f96 <45d0c2d7d338ae1606984ed92d254ca0efcef921, >=9952f3882ecba709092379b71e02b09762b26f96 <7dfe79db5615df8d37ae7de6d3ec099b71bf3e03, =7.3, >=7.2.10 <7.3 | 45d0c2d7d338ae1606984ed92d254ca0efcef921, 7dfe79db5615df8d37ae7de6d3ec099b71bf3e03, 7.3 |
| linux-kernel: Kernel | >=7.3.0 <7.3.5, >=7.2.10 <7.3 | 7.3.5, 7.3 |
Timeline
Every event on this vulnerability
Related
Other vulnerabilities in Kernel, strongest first
Embed
A live severity badge for an advisory, README or ticket